London | ITP-JAN-2016 | Ping Wang | Sprint 2 | form-controls #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pathywang
added
the
Needs Review
jenny-alexander
added
Review in progress
Contributor
jenny-alexander
left a comment
jenny-alexander
left a comment
There was a problem hiding this comment.
Hey @pathywang - great work with your form controls. 👍
I left a few comments for your to review.
| <header> | ||
| <h1>Product Pick</h1> | ||
| </header> | ||
| <main> |
Contributor
There was a problem hiding this comment.
Can you check to make sure you have the closing </main> tag?
| </div> | ||
| <br> | ||
| <div> | ||
| <p>Size</p> |
Contributor
There was a problem hiding this comment.
Your radio button labels and input work, but it is a bit unusual to have the label first and then the input.
For radio buttons, having the input defined first will be a bit more intuitive for users.
Here is an example: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input/radio#try_it
If you wrap your radio buttons inside of a <fieldset> and use a <legend>, then a screen reader will be able to announce the <legend> text along with each radio button, providing context to your user.
jenny-alexander
added
Reviewed
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
pathywang
added
Needs Review
Contributor
jenny-alexander
left a comment
jenny-alexander
left a comment
There was a problem hiding this comment.
Great job @pathywang!
jenny-alexander
added
Complete
Author
|
Many many thanks, Jenny.
Kind regards
Ping
…On Saturday, 24 January 2026, Jennifer Alexander ***@***.***> wrote:
***@***.**** commented on this pull request.
Great job @pathywang <https://github.com/pathywang>!
—
Reply to this email directly, view it on GitHub
<#989 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BR4KUR5XFUHOJJDF3GAQSXT4IODWDAVCNFSM6AAAAACSF6TPASVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTOMBRHAYTGMJYHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelist
i did code as requirement from readme.md, only use HTML code, no CSS style or JavaScript, i put on fieldset and also swap label and input in order to make my form more tidy.